Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

static libevent/curl support; adjusting file_exists behavior for php files; bugfixes #439

Closed
wants to merge 5 commits into
from

Conversation

Projects
None yet
2 participants

d1saster commented Dec 8, 2011

I think the commit messages are all self-explaining:
Two commits are real bugfixes (one for the issue #319 and one if you compile without __thread TLS support) and the other two commits just make it easier to deploy a compiled project.

d1saster added some commits Dec 3, 2011

Handle .php files differently in file_exists
Consider the following code

	if (file_exists('blub.php'))
		require_once ('blub.php');

which can fail because of 2 reasons:
1. blub.php is compiled with all the other files, but is no longer
   present at runtime.
2. blub.php is not compiled, but does exist in the filesystem.

The patch fixes the first case where file_exists now returns true
and adds a workaround for the second case where we now pretend that
the file does not exist.
fix the hphpi/eval support
The commit which changed 'file_exists' also changed the hphpi/eval
behavior. This patch fixes this in the way that we only pretend that local
.php files do not exist for compiled projects without eval support.
Contributor

ptarjan commented May 13, 2013

We're closing out all bugs older than 2 months. http://www.hiphop-php.com/wp/?p=575

If this is still an issue, please re-open it, and in order of goodness:

  1. Give detailed repro steps
  2. Write a test case in hphp/tests/quick (run it with hphp/tests/run) and send the pull request
  3. Fix it in a pull request

@ptarjan ptarjan closed this May 13, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment