Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix segfault with exceptions in object dtors and track_errors #4578

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@jmarrama
Copy link
Contributor

jmarrama commented Jan 6, 2015

This fixes the issue tracked in #4577 where throwing an exception
from an object destructor when the 'track_errors' ini setting is
on causes HHVM to segfault, due to accessing the frame pointer after
it has been destroyed.

Fix segfault with exceptions in object dtors and track_errors
This fixes the issue tracked in #4577 where throwing an exception
from an object destructor when the 'track_errors' ini setting is
on causes HHVM to segfault, due to accessing the frame pointer after
it has been destroyed.
@jmarrama

This comment has been minimized.

Copy link
Contributor Author

jmarrama commented Jan 6, 2015

This also fixes the same problem in HHVM 3.3.1

@facebook-github-bot

This comment has been minimized.

Copy link

facebook-github-bot commented Jan 6, 2015

This pull request has been imported into Phabricator, and discussion and review of the diff will take place at https://reviews.facebook.net/D30963

@hhvm-bot hhvm-bot closed this in cc75924 Jan 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.