Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a recoverable fatal on curl_init_pooled #6920

Conversation

@ebernhardson
Copy link
Contributor

ebernhardson commented Mar 17, 2016

curl_init_pooled has an unfortunate failure mode, when the pool is
exhausted the entire request fatals. This prevents the application from
gracefully handling the failure. The application could disable the
feature rather than canceling the entire request. In general fatal
errors should be reserved for cases where it is impossible to continue
processing the request, not simply because something went wrong. This
switches the fatal to a RuntimeException.

curl_init_pooled has an unfortunate failure mode, when the pool is
exhausted the entire request fatals. This prevents the application from
gracefully handling the failure. The application could disable the
feature rather than canceling the entire request. In general fatal
errors should be reserved for cases where it is impossible to continue
processing the request, not simply because something went wrong. This
switches the fatal to a RuntimeException.
@facebook-github-bot

This comment has been minimized.

Copy link

facebook-github-bot commented Mar 17, 2016

This pull request has been imported into Phabricator, and discussion and review of the diff will take place at https://reviews.facebook.net/D55689

@facebook-github-bot

This comment has been minimized.

Copy link

facebook-github-bot commented Mar 17, 2016

This pull request has been imported into Phabricator, and discussion and review of the diff will take place at https://reviews.facebook.net/D55689

@hhvm-bot hhvm-bot closed this in a4f8942 Mar 29, 2016
kmaslack added a commit to kmaslack/hhvm that referenced this pull request Apr 6, 2016
Summary:curl_init_pooled has an unfortunate failure mode, when the pool is
exhausted the entire request fatals. This prevents the application from
gracefully handling the failure. The application could disable the
feature rather than canceling the entire request. In general fatal
errors should be reserved for cases where it is impossible to continue
processing the request, not simply because something went wrong. This
switches the fatal to a RuntimeException.
Closes facebook#6920

Reviewed By: Orvid

Differential Revision: D3066969

fb-gh-sync-id: 7c3b92cad44627cb3ba67c88f847e5e500522ab0
fbshipit-source-id: 7c3b92cad44627cb3ba67c88f847e5e500522ab0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.