Update README.md #1150
Merged
Update README.md #1150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update Using TypeScript with Immutable.js v4
Update Using TypeScript with Immutable.js v4
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Formatting
Formatting
|
Thanks! |
errendir
added a commit
to errendir/immutable-js
that referenced
this pull request
Aug 24, 2017
…ings * facebook/master: (146 commits) Add descriptive titles (immutable-js#1244) expect setting Record property to throw (immutable-js#1194) Change the has method of Record to be a type guard (immutable-js#1232) Add back deleteIn() and removeIn() to Record (immutable-js#1179) Fix typo: change 'hiearchy' to 'hierarchy' (immutable-js#1222) Fix typo in OrderedMap#toKeyedSeq (immutable-js#1177) Fixes missing size property in flow types. (immutable-js#1173) Fix size of count() after filtering or flattening (immutable-js#1171) Support typescript strictNullChecks (immutable-js#1168) added links to header in docs immutable-js#356 (immutable-js#1164) Replace "an Collection" with "a Collection" everywhere (immutable-js#1163) Fix syntax highlighting and wrong variable names (immutable-js#1159) 4.0.0-rc.2 Adds back delete() and clear() to Record (immutable-js#1157) Improve filter typescript def to leverage predicate functions (immutable-js#1155) Improve type for reduce() (immutable-js#1156) Significant improvments to concat type definitions. (immutable-js#1153) Update README.md (immutable-js#1150) Add note for using with webpack Readme improvement pass ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that when using immutable.js v4, the TypeScript version needs to be higher than v.2.1.0, and need to use import instead of require