New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle java sources from a file #131

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@denizt

denizt commented Jul 8, 2015

The current way gradle plugin works is by parsing the verbose output to figure out which files to compile. This becomes a problem when the number of files exceed allowed argument parameter
length. Use javac's @sources file instead.

This patch will leave the tempfiles behind (also noted by Jyrki during the review), however I would like to leave that to a follow up commit and first make sure the tool works for people experiencing this problem.

Fixes #22

@jvillard

This comment has been minimized.

Show comment
Hide comment
@jvillard

jvillard Jul 8, 2015

Contributor

This looks great, thanks!

You could put the temporary file inside the directory named by self.args.infer_out to solve the issue of having temporary files lying around. You can even give it a fixed name and get rid of tempfile.

Contributor

jvillard commented Jul 8, 2015

This looks great, thanks!

You could put the temporary file inside the directory named by self.args.infer_out to solve the issue of having temporary files lying around. You can even give it a fixed name and get rid of tempfile.

@denizt

This comment has been minimized.

Show comment
Hide comment
@denizt

denizt Jul 8, 2015

self.args.infer_out sounds like it would solve the problem. The files are semantically temporary though, so I suggest leaving the tempfile

denizt commented Jul 8, 2015

self.args.infer_out sounds like it would solve the problem. The files are semantically temporary though, so I suggest leaving the tempfile

Deniz Türkoglu
Handle java sources from a file
The current way gradle plugin works is by parsing the verbose
output to figure out which files to compile. This becomes a
problem when the number of files exceed allowed argument parameter
length. Use javac's @sources file instead.

Reviewed-by: Jyrki Pulliainen <jyrki@spotify.com>
@denizt

This comment has been minimized.

Show comment
Hide comment
@denizt

denizt commented Jul 11, 2015

@jvillard ptal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment