Handle java sources from a file #131

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@denizt
denizt commented Jul 8, 2015

The current way gradle plugin works is by parsing the verbose output to figure out which files to compile. This becomes a problem when the number of files exceed allowed argument parameter
length. Use javac's @sources file instead.

This patch will leave the tempfiles behind (also noted by Jyrki during the review), however I would like to leave that to a follow up commit and first make sure the tool works for people experiencing this problem.

Fixes #22

@jvillard
Contributor
jvillard commented Jul 8, 2015

This looks great, thanks!

You could put the temporary file inside the directory named by self.args.infer_out to solve the issue of having temporary files lying around. You can even give it a fixed name and get rid of tempfile.

@denizt
denizt commented Jul 8, 2015

self.args.infer_out sounds like it would solve the problem. The files are semantically temporary though, so I suggest leaving the tempfile

Deniz Türkoglu Handle java sources from a file
The current way gradle plugin works is by parsing the verbose
output to figure out which files to compile. This becomes a
problem when the number of files exceed allowed argument parameter
length. Use javac's @sources file instead.

Reviewed-by: Jyrki Pulliainen <jyrki@spotify.com>
c76eee0
@denizt
denizt commented Jul 11, 2015

@jvillard ptal

@jvillard jvillard pushed a commit that closed this pull request Jul 14, 2015
=?UTF-8?q?Deniz=20T=C3=BCrkoglu?= Handle java sources from a file
Summary:
The current way gradle plugin works is by parsing the verbose output to figure out which files to compile. This becomes a problem when the number of files exceed allowed argument parameter
length. Use javac's @sources file instead.

This patch will leave the tempfiles behind (also noted by Jyrki during the review), however I would like to leave that to a follow up commit and first make sure the tool works for people experiencing this problem.

Fixes #22
Closes #131
Github Author: =?UTF-8?q?Deniz=20T=C3=BCrkoglu?= <deniz@spotify.com>
092e447
@jvillard jvillard closed this in 092e447 Jul 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment