add additional models for nullsafe and biabduction #1482
Conversation
|
Hi @cottamz! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
cottamz
changed the title
|
Thank you for your PR, this looks great. Let me know if you have issues with signing the CLA. I don't think we need the extra files in models/ for your purposes as these are only taken into account by the biabduction analysis. That said, it doesn't hurt to have them around too so up to you whether to leave them in or not. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
… and org.testng.Assert
cottamz
changed the title
The CLA is now signed.
I updated the pull request title indicating we are adding models for both nullsafe and biabduction. |
|
@jvillard has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@jvillard Could you share the Phabricator build and test output? |
|
@cottamz has updated the pull request. You must reimport the pull request before landing. |
|
This looks good overall but the changes in the biabduction models had surprising effects on other analyses, we're trying to figure out if we could limit these effects to the biabduction analysis. |
|
@cottamz has updated the pull request. You must reimport the pull request before landing. |
|
@cottamz has updated the pull request. You must reimport the pull request before landing. |
|
@jvillard has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
| $$(realpath $(1)) $$(realpath $(2)) >&2 || \ | ||
| $$(/Users/cottet/infer/infer/bin/realpath $(1)) $$(/Users/cottet/infer/infer/bin/realpath $(2)) >&2 || \ |
There was a problem hiding this comment.
Could you revert this change? It includes a user-specific path.
Please see CONTRIBUTING.md for how to set up your development environment and run tests.
java.util.Objects should be modeled in nullsafe:
https://docs.oracle.com/javase/8/docs/api/java/util/Objects.html