Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Travis CI slow execution + array.includes is not a function #1524
In my recent build for Grommet using Jest (:yay) I noticed the following console error:
Maybe we can replace includes by indexOf to avoid compatibility issues?
If you guys agree I can send a PR for that, otherwise what would be the recommended fix for this?
On a side note, I've noticed that my tests are taking a significantly longer time to execute in Travis when comparing to my local system. Is that expected?
This travis job is configured to use Node 5 and Jest test branch.
Are you using the free version of Travis, or the paid version? The free version is pretty resource-limited, so slowness is expected. The paid version has much more CPU power available.
As a side note - Node v5 is EOL... v4 is the LTS release and v6 is the 'current' release. You should switch to either v4 or v6 depending on whether you want a release with long-term support (v4) or a release with the latest features (v6)
We probably have memory leaks in our tests, but another helpful fix for running specs in docker was the node flag
karma (running in an x-window for the sake of running headless Chrome), for comparison:
jest with both
Our speed would probably be helped most by addressing memory leaks, but wanted to leave the trail in case someone else found it useful.