Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slim Dependencies #2691

Closed
cpojer opened this issue Jan 25, 2017 · 12 comments

Comments

Projects
None yet
8 participants
@cpojer
Copy link
Contributor

commented Jan 25, 2017

Also see facebook/create-react-app#1183

We should focus on reducing the amount of dependencies that are shipped with Jest. Is there somebody that could do an analysis?

@wtgtybhertgeghgtwtg

This comment has been minimized.

Copy link
Contributor

commented Jan 26, 2017

I thought I was dreaming when I saw this issue.

@cpojer

This comment has been minimized.

Copy link
Contributor Author

commented Jan 26, 2017

ah, it sucks that all of these are transitive dependencies and that we don't really have much control over it.

@kentcdodds

This comment has been minimized.

Copy link
Contributor

commented Jan 26, 2017

Can I just say that @wtgtybhertgeghgtwtg's analysis is incredibly thorough. Thank you for doing that

giphy

@orta

This comment has been minimized.

Copy link
Collaborator

commented Jan 26, 2017

Yep, this is really great work - thanks @wtgtybhertgeghgtwtg

@cpojer

This comment has been minimized.

Copy link
Contributor Author

commented Jan 27, 2017

note-notifier dropped the cli: #2718

@JaKXz

This comment has been minimized.

Copy link

commented Jan 29, 2017

@cpojer

This comment has been minimized.

Copy link
Contributor Author

commented Jan 29, 2017

Nice!

@wtgtybhertgeghgtwtg

This comment has been minimized.

Copy link
Contributor

commented Feb 21, 2017

Just an overview of the impact this has had.
jest@19.0.0 is about seven dependencies and one megabyte lighter than jest@18.1.0. Here's a comparison of the node_modules of a fresh install of the two (Windows 10, yarn@0.20.3)
jest 18 1 0 vs jest 19 0 0

@cpojer

This comment has been minimized.

Copy link
Contributor Author

commented Feb 21, 2017

Nice work, thanks @wtgtybhertgeghgtwtg for working on this and getting back with more data :)

@wtgtybhertgeghgtwtg wtgtybhertgeghgtwtg referenced this issue Feb 21, 2017

Closed

Slim Dependencies #1183

3 of 11 tasks complete
@mhart

This comment has been minimized.

Copy link

commented Mar 14, 2017

It was lighter until request v2.80.0 went ahead and destroyed all the gains:

http://pkgsize.com/jest.html (select an area to zoom in and hover to see the event that caused the change)

which is largely:

http://pkgsize.com/jest-cli.html

The big ones there are:

@sanyatuning

This comment has been minimized.

Copy link

commented Apr 20, 2017

+1

@cpojer

This comment has been minimized.

Copy link
Contributor Author

commented Dec 15, 2017

I think we are mostly good on this for now and we sped Jest's startup up by more than 50% with Jest 21. If anybody wants to drop more stuff, please feel free to comment here and send PRs!

@cpojer cpojer closed this Dec 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.