Symbols in objects and toEqual

[alondahari]

Hi,
Current behavior:

const sym = Symbol('dude')
const obj1 = { [sym]: 'one' }
const obj2 = { [sym]: 'two' }

expect(obj1).toBe(obj1) // fail
expect(obj1).toEqual(obj1) // pass
expect(obj1).toEqual(obj2) // pass!

expected behavior:

expect(obj1).toBe(obj1) // fail
expect(obj1).toEqual(obj1) // pass
expect(obj1).toEqual(obj2) // fail

Thanks!

[pedrottimark]

As first step to dig into this, all three assertions pass in Jasmine 2.6.0

@jazzdragon Help me understand why expected result of expect(obj1).toBe(obj1) is fail?

console.log(obj1 === obj1); // true in Node 7.9.0

Concerning toEqual a for-in loop in keys helper function does not enumerate symbols at:

• https://github.com/facebook/jest/blob/master/packages/jest-matchers/src/jasmine-utils.js#L211
• https://github.com/jasmine/jasmine/blob/master/src/core/matchers/matchersUtil.js#L313

Before going any farther, are we willing to call Object.getOwnPropertySymbols also?

For more information:

• https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Symbol#Symbols_and_for...in_iteration
• https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/getOwnPropertySymbols

[alondahari]

My bad, what I really meant is this setup:

const sym = Symbol('dude')
const obj1 = { [sym]: 'one' }
const obj2 = { [sym]: 'two' }
const obj3 = { [sym]: 'one' }

and then:

expect(obj1).toBe(obj3) // fail - good
expect(obj1).toEqual(obj3) // pass - good
expect(obj1).toEqual(obj2) // pass - no good!

Sorry for the confusion. I wouldn't normally test an object against itself, but against another one with the same structure...

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.