Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: simplify transform RegExp #10207

Merged
merged 8 commits into from Oct 19, 2020
Merged

fix: simplify transform RegExp #10207

merged 8 commits into from Oct 19, 2020

Conversation

@elado
Copy link
Contributor

@elado elado commented Jun 26, 2020

Summary

Before

"^.+\\.[t|j]sx?$": "babel-jest"

After

"\\.[jt]sx?$": "babel-jest"

RegExp's [] doesn't need |, in fact, it adds it to the character list it looks for (/[t|j]/.test('|') === true). Also since we care only about the suffix, no reason for ^.+.

Before
```
"^.+\\.[t|j]sx?$": "babel-jest"
```
After
```
"\\.[jt]sx?$": "babel-jest"
```

RegExp's `[]` doesn't need `|`, in fact, it adds it to the character list it looks for (`/[t|j]/.test('|') === true`). Also since we care only about the suffix, no reason for `^.+`.
@elado elado changed the title Update file regexp for babel-jest Update README: file regexp for babel-jest Jun 26, 2020
@facebook-github-bot
Copy link
Contributor

@facebook-github-bot facebook-github-bot commented Jun 26, 2020

Hi @elado!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

@facebook-github-bot facebook-github-bot commented Jun 27, 2020

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@SimenB
SimenB approved these changes Jul 3, 2020
Copy link
Collaborator

@SimenB SimenB left a comment

Thanks! Should we update any code as well? E.g.

export const DEFAULT_JS_PATTERN = '^.+\\.[jt]sx?$';
and potentially other places

elado added 3 commits Jul 5, 2020
;
@SimenB
SimenB approved these changes Oct 19, 2020
Copy link
Collaborator

@SimenB SimenB left a comment

Forgot this 😬 LGTM, thanks!

@SimenB SimenB changed the title Update README: file regexp for babel-jest fix: simplify transform RegExp Oct 19, 2020
@SimenB SimenB merged commit 7d7e97f into facebook:master Oct 19, 2020
21 of 22 checks passed
21 of 22 checks passed
cleanup-runs
Details
Running TypeScript compiler & ESLint
Details
Node v10.x on ubuntu-latest
Details
Node v10.x on macOS-latest
Details
Node v10.x on windows-latest
Details
Node v12.x on ubuntu-latest
Details
Node v12.x on macOS-latest
Details
Node v12.x on windows-latest
Details
Node v13.x on ubuntu-latest
Details
Node v13.x on macOS-latest
Details
Node v13.x on windows-latest
Details
Node v14.x on ubuntu-latest
Details
Node v14.x on macOS-latest
Details
Node v14.x on windows-latest
Details
facebook.jest in progress
Details
Facebook CLA Check Contributor License Agreement is valid!
Details
ci/circleci: test-jest-circus Your tests passed on CircleCI!
Details
ci/circleci: test-node-10 Your tests passed on CircleCI!
Details
ci/circleci: test-node-12 Your tests passed on CircleCI!
Details
ci/circleci: test-node-13 Your tests passed on CircleCI!
Details
ci/circleci: test-node-14 Your tests passed on CircleCI!
Details
ci/circleci: test-or-deploy-website Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.