Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add console.timeLog function #10209

Merged
merged 2 commits into from Jul 3, 2020
Merged

Add console.timeLog function #10209

merged 2 commits into from Jul 3, 2020

Conversation

@webstech
Copy link
Contributor

webstech commented Jun 27, 2020

Provide timeLog to be compatible with node.

Summary

console.timeLog was added in node v10.7.0. Jest gets errors when the function is used. A stackoverflow question was never explained.

Test plan

Tests were added to the files in the test directory. A test run was successful. These are basic jest tests.

@webstech webstech force-pushed the webstech:cw/console branch 3 times, most recently from ddb6203 to d5716a2 Jun 27, 2020
Provide timeLog to be compatible with node.

Signed-off-by: Chris. Webster <chris@webstech.net>
@webstech webstech force-pushed the webstech:cw/console branch from d5716a2 to ebdcec0 Jul 3, 2020
@webstech
Copy link
Contributor Author

webstech commented Jul 3, 2020

Rebased and merged CHANGELOG.md. Should not have caused macOS test to fail after previously running okay.

@SimenB
SimenB approved these changes Jul 3, 2020
Copy link
Collaborator

SimenB left a comment

thanks!

@SimenB SimenB merged commit 6005d7e into facebook:master Jul 3, 2020
14 of 22 checks passed
14 of 22 checks passed
cleanup-runs
Details
Running TypeScript compiler & ESLint
Details
Node v10.x on ubuntu-latest
Details
Node v10.x on macOS-latest
Details
Node v10.x on windows-latest
Details
Node v12.x on ubuntu-latest
Details
Node v12.x on macOS-latest
Details
Node v12.x on windows-latest
Details
Node v13.x on ubuntu-latest
Details
Node v13.x on macOS-latest
Details
Node v13.x on windows-latest
Details
Node v14.x on ubuntu-latest
Details
Node v14.x on macOS-latest
Details
Node v14.x on windows-latest
Details
ci/circleci: test-jest-circus CircleCI is running your tests
Details
ci/circleci: test-node-10 CircleCI is running your tests
Details
ci/circleci: test-node-12 CircleCI is running your tests
Details
ci/circleci: test-node-13 CircleCI is running your tests
Details
ci/circleci: test-node-14 CircleCI is running your tests
Details
ci/circleci: test-or-deploy-website CircleCI is running your tests
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
facebook.jest queued
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.