Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert PCancelable to typescript #10215

Merged
merged 6 commits into from Jul 4, 2020

Conversation

@G-Rath
Copy link
Contributor

G-Rath commented Jun 28, 2020

Summary

Found while looking to remove some usages of Function type for #10177.

By converting PCancelable to TypeScript, the Function types can be dropped in favor of the types being inferred.
I also axed the canceled getter, and fn static property as they're not used, and the latter is painful to accurately type.

Finally, also typed the return of queueRunner & refined some any types.

Test plan

Ran the build, TypeScript was happy.

@G-Rath G-Rath force-pushed the G-Rath:convert-PCancelable-to-typescript branch from 39bff21 to eab3e3b Jun 28, 2020
@SimenB
SimenB approved these changes Jun 29, 2020
Copy link
Collaborator

SimenB left a comment

thanks!

packages/jest-jasmine2/src/queueRunner.ts Outdated Show resolved Hide resolved
@SimenB SimenB merged commit e8b7f57 into facebook:master Jul 4, 2020
22 checks passed
22 checks passed
cleanup-runs
Details
Running TypeScript compiler & ESLint
Details
Node v10.x on ubuntu-latest
Details
Node v10.x on macOS-latest
Details
Node v10.x on windows-latest
Details
Node v12.x on ubuntu-latest
Details
Node v12.x on macOS-latest
Details
Node v12.x on windows-latest
Details
Node v13.x on ubuntu-latest
Details
Node v13.x on macOS-latest
Details
Node v13.x on windows-latest
Details
Node v14.x on ubuntu-latest
Details
Node v14.x on macOS-latest
Details
Node v14.x on windows-latest
Details
ci/circleci: test-jest-circus Your tests passed on CircleCI!
Details
ci/circleci: test-node-10 Your tests passed on CircleCI!
Details
ci/circleci: test-node-12 Your tests passed on CircleCI!
Details
ci/circleci: test-node-13 Your tests passed on CircleCI!
Details
ci/circleci: test-node-14 Your tests passed on CircleCI!
Details
ci/circleci: test-or-deploy-website Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
facebook.jest #20200703.31 succeeded
Details
@G-Rath G-Rath deleted the G-Rath:convert-PCancelable-to-typescript branch Jul 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.