Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
feat: pretty-print web components properly #10237
--added support for properly serializing/printing custom elements by pretty-print
Previously serializing the custom elements would not be handled properly by DOMElement plugin of pretty-print and instead of element's HTML markup all of the custom element properties along with it's constructor name would be printed instead. Now custom elements will be treated in DOMElement plugin as the built-in DOM elements.
Unit tests were written so
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.
In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
If you have received this in error or have any questions, please contact us at firstname.lastname@example.org. Thanks!
@zaalbarxx seems this has caused a regression somehow: https://app.circleci.com/pipelines/github/storybookjs/storybook/12354/workflows/e8752f72-9082-42c5-87b3-d07ea7053a95/jobs/249451