Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing dependency on `@types/node` to all packages #10248

Merged
merged 9 commits into from Jul 5, 2020

Conversation

@SimenB
Copy link
Collaborator

SimenB commented Jul 5, 2020

Summary

PnP complains in #9476.

Usages:

import type {Context, Script} from 'vm';

Omit<NodeJS.Global, keyof GlobalAdditions> {

Test plan

Green CI

SimenB added 2 commits Jul 5, 2020
SimenB added 5 commits Jul 5, 2020
@SimenB SimenB changed the title Add missing dependency on `@types/node` to `@jest/types` and `@jest/environment` Add missing dependency on `@types/node` to all packages Jul 5, 2020
SimenB added 2 commits Jul 5, 2020
@SimenB SimenB merged commit 444e62f into facebook:master Jul 5, 2020
22 checks passed
22 checks passed
cleanup-runs
Details
Running TypeScript compiler & ESLint
Details
Node v10.x on ubuntu-latest
Details
Node v10.x on macOS-latest
Details
Node v10.x on windows-latest
Details
Node v12.x on ubuntu-latest
Details
Node v12.x on macOS-latest
Details
Node v12.x on windows-latest
Details
Node v13.x on ubuntu-latest
Details
Node v13.x on macOS-latest
Details
Node v13.x on windows-latest
Details
Node v14.x on ubuntu-latest
Details
Node v14.x on macOS-latest
Details
Node v14.x on windows-latest
Details
ci/circleci: test-jest-circus Your tests passed on CircleCI!
Details
ci/circleci: test-node-10 Your tests passed on CircleCI!
Details
ci/circleci: test-node-12 Your tests passed on CircleCI!
Details
ci/circleci: test-node-13 Your tests passed on CircleCI!
Details
ci/circleci: test-node-14 Your tests passed on CircleCI!
Details
ci/circleci: test-or-deploy-website Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
facebook.jest #20200705.46 succeeded
Details
@SimenB SimenB deleted the SimenB:missing-types-node-dep branch Jul 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.