Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly handle arrays in snapshot deep merge #10404

Merged
merged 1 commit into from Aug 14, 2020

Conversation

@jimmydief
Copy link
Contributor

@jimmydief jimmydief commented Aug 13, 2020

Summary

Fixes #10403.

Test plan

Added tests.

James Diefenderfer
@jimmydief jimmydief force-pushed the jimmydief:array_snapshot_property_matchers branch from 5fcc6ec to 627b352 Aug 14, 2020
@SimenB
SimenB approved these changes Aug 14, 2020
Copy link
Collaborator

@SimenB SimenB left a comment

Thanks!

@SimenB SimenB merged commit c9c8dba into facebook:master Aug 14, 2020
22 checks passed
22 checks passed
cleanup-runs
Details
Running TypeScript compiler & ESLint
Details
Node v10.x on ubuntu-latest
Details
Node v10.x on macOS-latest
Details
Node v10.x on windows-latest
Details
Node v12.x on ubuntu-latest
Details
Node v12.x on macOS-latest
Details
Node v12.x on windows-latest
Details
Node v13.x on ubuntu-latest
Details
Node v13.x on macOS-latest
Details
Node v13.x on windows-latest
Details
Node v14.x on ubuntu-latest
Details
Node v14.x on macOS-latest
Details
Node v14.x on windows-latest
Details
Facebook CLA Check Contributor License Agreement is valid!
Details
ci/circleci: test-jest-circus Your tests passed on CircleCI!
Details
ci/circleci: test-node-10 Your tests passed on CircleCI!
Details
ci/circleci: test-node-12 Your tests passed on CircleCI!
Details
ci/circleci: test-node-13 Your tests passed on CircleCI!
Details
ci/circleci: test-node-14 Your tests passed on CircleCI!
Details
ci/circleci: test-or-deploy-website Your tests passed on CircleCI!
Details
facebook.jest #20200814.1 succeeded
Details
@jimmydief jimmydief deleted the jimmydief:array_snapshot_property_matchers branch Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.