Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make requiring from outside the Jest VM easier w/ a Babel plugin #10824

Merged
merged 2 commits into from
Nov 14, 2020

Conversation

jeysal
Copy link
Contributor

@jeysal jeysal commented Nov 14, 2020

Summary

See title.
And rename the Symbol to align with other Symbols that we have and use.
in Babel plugins

Test plan

Works when I use it in #7792

and rename the Symbol to align with other Symbols that we have and use
in Babel plugins
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog entry pls 😀

packages/jest-types/src/Global.ts Outdated Show resolved Hide resolved
scripts/babel-plugin-jest-require-outside-vm.js Outdated Show resolved Hide resolved
@jeysal
Copy link
Contributor Author

jeysal commented Nov 14, 2020

What would the changelog entry say though? This is internal and concerns 0 of our packages because it's not even used yet 🙈

@jeysal jeysal requested a review from SimenB November 14, 2020 17:16
@SimenB SimenB changed the title make requiring from outside the Jest VM easier w/ a Babel plugin chore: make requiring from outside the Jest VM easier w/ a Babel plugin Nov 14, 2020
@SimenB SimenB merged commit e66a0e8 into master Nov 14, 2020
@SimenB SimenB deleted the require-outside-babel branch November 14, 2020 18:16
jeysal added a commit to mmkal/jest that referenced this pull request Nov 14, 2020
* master:
  chore: make requiring from outside the Jest VM easier w/ a Babel plugin (jestjs#10824)
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants