Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
workaround for windows to ensure console.log is always flushed before pr... #111
I'm not sure the problem with tests "continuing to execute" makes sense. If all jest tests are synchronous, then the initial thrown exception should terminate the tests anyway, so there shouldn't be any need to worry about that?
@jeffmo If you want me to re-write this to use the 'exit' module I'm happy to make that change.
@jeffmo Thanks, I think I understand now. I had assumed you meant that comment to apply to all the process.exit calls, but it makes far more sense for just the
referenced this pull request
Dec 17, 2014
I am happy to take this, but it's in a place where it needs some refactoring (and bin/jest.js has changed since this was written). I would go in and just finish this up myself (seems fairly straightforward), but I don't have a working Windows machine to try to port this to the latest code...so I wouldn't feel comfortable doing so without being able to verify and test.
Could either @malonecj or someone else who's running on windows finish this out and confirm that it fixes things? I'm happy to take it if we can get the stop-execution problem worked out (the thing I commented inline)