Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs: Update MockFunctions.md #11556

Merged
merged 2 commits into from Jun 21, 2021
Merged

Fix docs: Update MockFunctions.md #11556

merged 2 commits into from Jun 21, 2021

Conversation

@seastian
Copy link
Contributor

@seastian seastian commented Jun 10, 2021

Summary

Wrong order in array. Should check on second call.

Test plan

@facebook-github-bot
Copy link
Contributor

@facebook-github-bot facebook-github-bot commented Jun 10, 2021

Hi @seastian!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@codecov-commenter
Copy link

@codecov-commenter codecov-commenter commented Jun 10, 2021

Codecov Report

Merging #11556 (9a866d0) into master (d1882f2) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11556      +/-   ##
==========================================
- Coverage   68.94%   68.93%   -0.01%     
==========================================
  Files         312      312              
  Lines       16314    16314              
  Branches     4726     4726              
==========================================
- Hits        11247    11246       -1     
- Misses       5039     5040       +1     
  Partials       28       28              
Impacted Files Coverage Δ
packages/expect/src/utils.ts 95.58% <0.00%> (-0.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1882f2...9a866d0. Read the comment docs.

@facebook-github-bot
Copy link
Contributor

@facebook-github-bot facebook-github-bot commented Jun 10, 2021

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

SimenB
SimenB approved these changes Jun 14, 2021
Copy link
Collaborator

@SimenB SimenB left a comment

thanks! could you update the versioned docs as well?
image

@seastian
Copy link
Contributor Author

@seastian seastian commented Jun 19, 2021

That should be it. Thanks!

@SimenB SimenB merged commit 6308b6c into facebook:master Jun 21, 2021
9 checks passed
@github-actions
Copy link

@github-actions github-actions bot commented Jul 22, 2021

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 22, 2021
@seastian seastian deleted the patch-1 branch Aug 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants