Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: enable syntax highlighting to a code block #11594

Merged
merged 2 commits into from Jun 21, 2021

Conversation

@huyenltnguyen
Copy link
Contributor

@huyenltnguyen huyenltnguyen commented Jun 21, 2021

Summary

A code block under the jest.createMockFromModule section is not having syntax highlighting.

Screen Shot 2021-06-21 at 13 20 59

Test plan

Screenshot of the change

Screen Shot 2021-06-21 at 13 24 37

@facebook-github-bot
Copy link
Contributor

@facebook-github-bot facebook-github-bot commented Jun 21, 2021

Hi @huyenltnguyen!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@codecov-commenter
Copy link

@codecov-commenter codecov-commenter commented Jun 21, 2021

Codecov Report

Merging #11594 (4324ed6) into master (7be63ef) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #11594   +/-   ##
=======================================
  Coverage   69.00%   69.00%           
=======================================
  Files         312      312           
  Lines       16331    16331           
  Branches     4730     4730           
=======================================
  Hits        11269    11269           
  Misses       5034     5034           
  Partials       28       28           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7be63ef...4324ed6. Read the comment docs.

@facebook-github-bot
Copy link
Contributor

@facebook-github-bot facebook-github-bot commented Jun 21, 2021

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

SimenB
SimenB approved these changes Jun 21, 2021
Copy link
Collaborator

@SimenB SimenB left a comment

Thanks! Can you update the versioned docs as well?

image

@huyenltnguyen
Copy link
Contributor Author

@huyenltnguyen huyenltnguyen commented Jun 21, 2021

Ah, sorry I missed them. Updated.

SimenB
SimenB approved these changes Jun 21, 2021
Copy link
Collaborator

@SimenB SimenB left a comment

thanks!

@SimenB SimenB merged commit 0a210dc into facebook:master Jun 21, 2021
2 of 9 checks passed
@huyenltnguyen huyenltnguyen deleted the patch-1 branch Jun 21, 2021
@github-actions
Copy link

@github-actions github-actions bot commented Jul 22, 2021

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants