Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jest-environment] adding mocked in jest object #12133

Merged
merged 5 commits into from Dec 10, 2021
Merged

[jest-environment] adding mocked in jest object #12133

merged 5 commits into from Dec 10, 2021

Conversation

k-rajat19
Copy link
Contributor

@k-rajat19 k-rajat19 commented Dec 8, 2021

Summary

Closes #12131

also updated https://jestjs.io/docs/jest-object as it was not added in #12089

@SimenB
Copy link
Collaborator

@SimenB SimenB commented Dec 8, 2021

@k-rajat19 could you fix the lint errors? 🙂

@k-rajat19
Copy link
Contributor Author

@k-rajat19 k-rajat19 commented Dec 8, 2021

Yeah
I manually fixes some issues. Not able to fix with --fix option

@codecov-commenter
Copy link

@codecov-commenter codecov-commenter commented Dec 8, 2021

Codecov Report

Merging #12133 (55c9faa) into main (c76f9a7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #12133   +/-   ##
=======================================
  Coverage   67.71%   67.71%           
=======================================
  Files         328      328           
  Lines       16990    16991    +1     
  Branches     4817     4817           
=======================================
+ Hits        11505    11506    +1     
  Misses       5452     5452           
  Partials       33       33           
Impacted Files Coverage Δ
packages/jest-runtime/src/index.ts 56.74% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c76f9a7...55c9faa. Read the comment docs.

SimenB
SimenB approved these changes Dec 10, 2021
Copy link
Collaborator

@SimenB SimenB left a comment

thanks!

@SimenB SimenB merged commit 2dabd5c into facebook:main Dec 10, 2021
33 of 34 checks passed
@SimenB
Copy link
Collaborator

@SimenB SimenB commented Dec 10, 2021

I forgot, but pushed up 396ea96 now which should deploy a new version of the docs

@k-rajat19
Copy link
Contributor Author

@k-rajat19 k-rajat19 commented Dec 10, 2021

Bt why this is showing 27.2 latest
https://jestjs.io/docs/jest-object ? 🙂

@SimenB
Copy link
Collaborator

@SimenB SimenB commented Dec 10, 2021

Yeah, there's a bug in docusaurus, the build failed: https://app.netlify.com/sites/jestjs/deploys/61b32b0915d7a2000880d9ea

@SimenB
Copy link
Collaborator

@SimenB SimenB commented Dec 10, 2021

retry: 846f312

@github-actions
Copy link

@github-actions github-actions bot commented Jan 10, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants