Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update pirates to 4.0.4 #12136

Merged
merged 8 commits into from Dec 16, 2021
Merged

fix: update pirates to 4.0.4 #12136

merged 8 commits into from Dec 16, 2021

Conversation

laozhu
Copy link
Contributor

@laozhu laozhu commented Dec 9, 2021

Related to issue #75

Cannot find module '/Users/Ritchie/Developer/@fastcms/fastcms/node_modules/.pnpm/@jest+transform@27.4.2/node_modules/pirates/lib/index.js'. Please verify that the package.json has a valid "main" entry

Related to issue [#75](danez/pirates#75)


```
Cannot find module '/Users/Ritchie/Developer/@fastcms/fastcms/node_modules/.pnpm/@jest+transform@27.4.2/node_modules/pirates/lib/index.js'. Please verify that the package.json has a valid "main" entry
```
@facebook-github-bot
Copy link
Contributor

@facebook-github-bot facebook-github-bot commented Dec 9, 2021

Hi @laozhu!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

Copy link
Collaborator

@SimenB SimenB left a comment

Hey @laozhu, and thanks for the PR! Could you sign the CLA and run yarn (plus update the changelog)?

@SimenB
Copy link
Collaborator

@SimenB SimenB commented Dec 15, 2021

Ping @laozhu

@laozhu
Copy link
Contributor Author

@laozhu laozhu commented Dec 15, 2021

Sorry, I forgot this issue, will deal with this pr tonight 😄

@facebook-github-bot
Copy link
Contributor

@facebook-github-bot facebook-github-bot commented Dec 15, 2021

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

SimenB
SimenB approved these changes Dec 15, 2021
Copy link
Collaborator

@SimenB SimenB left a comment

thanks!

@codecov-commenter
Copy link

@codecov-commenter codecov-commenter commented Dec 15, 2021

Codecov Report

Merging #12136 (2492320) into main (6d101e9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #12136   +/-   ##
=======================================
  Coverage   67.71%   67.71%           
=======================================
  Files         328      328           
  Lines       16991    16991           
  Branches     4817     4817           
=======================================
  Hits        11506    11506           
  Misses       5452     5452           
  Partials       33       33           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d101e9...2492320. Read the comment docs.

@SimenB SimenB changed the title Update pirates to 4.0.4 to fix no entry problem fix: update pirates to 4.0.4 Dec 16, 2021
@SimenB SimenB merged commit 2b78dd2 into facebook:main Dec 16, 2021
3 of 12 checks passed
@laozhu laozhu deleted the patch-1 branch Dec 16, 2021
@github-actions
Copy link

@github-actions github-actions bot commented Jan 16, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants