Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename test directory name from __test__ to __tests__ #12144

Conversation

4geru
Copy link
Contributor

@4geru 4geru commented Dec 13, 2021

Summary

Changed from test to tests.
The directory to test with Javascript is defined in tests. Jest is a test library, I think it should exprein as a test model.

Test plan

@facebook-github-bot
Copy link
Contributor

@facebook-github-bot facebook-github-bot commented Dec 13, 2021

Hi @4geru!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@4geru
Copy link
Contributor Author

@4geru 4geru commented Dec 13, 2021

CLA signed 👍

@facebook-github-bot
Copy link
Contributor

@facebook-github-bot facebook-github-bot commented Dec 13, 2021

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

SimenB
SimenB approved these changes Dec 13, 2021
Copy link
Collaborator

@SimenB SimenB left a comment

thanks!

@SimenB SimenB changed the title rename test directory name from __test__ to __tests__ chore: rename test directory name from __test__ to __tests__ Dec 13, 2021
@SimenB SimenB merged commit 07c2c15 into facebook:main Dec 13, 2021
32 of 34 checks passed
@github-actions
Copy link

@github-actions github-actions bot commented Jan 13, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants