Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime): handle missing mocked property #12213

Merged
merged 3 commits into from Jan 4, 2022

Conversation

SimenB
Copy link
Collaborator

@SimenB SimenB commented Jan 4, 2022

Summary

Fixes #12200

Test plan

E2E test added

@codecov-commenter
Copy link

@codecov-commenter codecov-commenter commented Jan 4, 2022

Codecov Report

Merging #12213 (37cc983) into main (4eabd9d) will decrease coverage by 0.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12213      +/-   ##
==========================================
- Coverage   67.53%   67.51%   -0.02%     
==========================================
  Files         328      328              
  Lines       17244    17246       +2     
  Branches     5069     5071       +2     
==========================================
- Hits        11645    11644       -1     
- Misses       5566     5569       +3     
  Partials       33       33              
Impacted Files Coverage Δ
packages/jest-runtime/src/index.ts 56.47% <33.33%> (-0.13%) ⬇️
packages/expect/src/utils.ts 96.03% <0.00%> (-0.50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4eabd9d...37cc983. Read the comment docs.

@SimenB SimenB merged commit fcd626d into facebook:main Jan 4, 2022
25 of 33 checks passed
@SimenB SimenB deleted the handle-missing-mocked branch Jan 4, 2022
@github-actions
Copy link

@github-actions github-actions bot commented Feb 4, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants