Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: binary scripts should use package exports #12315

Merged
merged 3 commits into from Feb 7, 2022

Conversation

SimenB
Copy link
Collaborator

@SimenB SimenB commented Feb 7, 2022

Summary

Instead of reaching into build/ we should use the exported API. This also ensures it keeps working when we bundle without changes

Test plan

Green CI.

I've tested calling the binary files still work

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2022

Codecov Report

Merging #12315 (c5b34df) into main (a9b7e8a) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12315      +/-   ##
==========================================
- Coverage   67.25%   67.25%   -0.01%     
==========================================
  Files         329      330       +1     
  Lines       17353    17354       +1     
  Branches     5074     5074              
==========================================
  Hits        11671    11671              
- Misses       5650     5651       +1     
  Partials       32       32              
Impacted Files Coverage Δ
packages/jest-repl/src/index.ts 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9b7e8a...c5b34df. Read the comment docs.

@SimenB SimenB merged commit 3a7e1c9 into facebook:main Feb 7, 2022
33 checks passed
@SimenB SimenB deleted the bin-use-package-exports branch Feb 7, 2022
@github-actions
Copy link

github-actions bot commented Mar 11, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants