Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(jest-config): remove unused dev dep #12319

Merged
merged 4 commits into from Feb 7, 2022
Merged

chore(jest-config): remove unused dev dep #12319

merged 4 commits into from Feb 7, 2022

Conversation

Biki-das
Copy link
Contributor

@Biki-das Biki-das commented Feb 7, 2022

this Pr removes some of the imports within files which were unused

e2e/override-globals/__tests__/index.js Outdated Show resolved Hide resolved
@Biki-das
Copy link
Contributor Author

Biki-das commented Feb 7, 2022

@SimenB done :-)

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2022

Codecov Report

Merging #12319 (bf368ea) into main (bc1c884) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #12319   +/-   ##
=======================================
  Coverage   67.25%   67.25%           
=======================================
  Files         330      330           
  Lines       17354    17354           
  Branches     5073     5073           
=======================================
  Hits        11671    11671           
  Misses       5651     5651           
  Partials       32       32           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc1c884...bf368ea. Read the comment docs.

@Biki-das Biki-das requested a review from SimenB Feb 7, 2022
SimenB
SimenB approved these changes Feb 7, 2022
@Biki-das
Copy link
Contributor Author

Biki-das commented Feb 7, 2022

@mrazauskas hey how do i remove it i mean i dont know much about npm packages, like could you help me a bit.

@mrazauskas
Copy link
Contributor

mrazauskas commented Feb 7, 2022

Just delete the entry in packages/jest-config/package.json, run yarn in the root of jest repo and commit that package.json + yarn.lock (this should be generated after you ran yarn).

@Biki-das
Copy link
Contributor Author

Biki-das commented Feb 7, 2022

Just delete the entry in packages/jest-config/package.json, run yarn in the root of jest repo and commit that package.json + yarn.lock (this should be generated after you ran yarn).

thanks

@SimenB
Copy link
Collaborator

SimenB commented Feb 7, 2022

yarn workspace jest-config remove strip-ansi also works 🙂

@Biki-das
Copy link
Contributor Author

Biki-das commented Feb 7, 2022

yarn workspace jest-config remove strip-ansi also works 🙂

thanks changes done :-)

@Biki-das Biki-das requested a review from SimenB Feb 7, 2022
SimenB
SimenB approved these changes Feb 7, 2022
@SimenB SimenB changed the title Fix:removed unused import chore(jest-config): remove unused dev dep Feb 7, 2022
@SimenB SimenB merged commit 1596aab into facebook:main Feb 7, 2022
30 of 33 checks passed
@Biki-das Biki-das deleted the import-remove branch Feb 8, 2022
@github-actions
Copy link

github-actions bot commented Mar 11, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants