Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: stop shipping jsdom by default #12354

Merged
merged 2 commits into from Feb 10, 2022
Merged

Conversation

SimenB
Copy link
Collaborator

@SimenB SimenB commented Feb 10, 2022

Summary

As announced in the Jest v27 blog post, we'll stop shipping jsdom and jasmine by default. This PR removes JSDOM.

Test plan

Green CI

@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2022

Codecov Report

Merging #12354 (b48a162) into main (a651b65) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12354      +/-   ##
==========================================
- Coverage   66.94%   66.92%   -0.02%     
==========================================
  Files         329      329              
  Lines       17345    17350       +5     
  Branches     5059     5060       +1     
==========================================
  Hits        11612    11612              
- Misses       5701     5706       +5     
  Partials       32       32              
Impacted Files Coverage Δ
packages/jest-config/src/ValidConfig.ts 100.00% <ø> (ø)
packages/jest-resolve/src/utils.ts 23.68% <0.00%> (-3.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a651b65...b48a162. Read the comment docs.

@SimenB SimenB merged commit a8e997a into facebook:main Feb 10, 2022
26 checks passed
@SimenB SimenB deleted the remove-jsdom-default branch Feb 10, 2022
@github-actions
Copy link

github-actions bot commented Mar 13, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants