Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jest-config): Throw an error instead of showing a warning if multiple configs are used #12510

Merged
merged 3 commits into from Feb 28, 2022

Conversation

TrickyPi
Copy link
Contributor

@TrickyPi TrickyPi commented Feb 28, 2022

Summary

Closes #12506

Test plan

I wrote/updated specific tests.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Feb 28, 2022

Hi @TrickyPi!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Feb 28, 2022

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

SimenB
SimenB approved these changes Feb 28, 2022
Copy link
Collaborator

@SimenB SimenB left a comment

thanks!

@TrickyPi
Copy link
Contributor Author

TrickyPi commented Feb 28, 2022

thanks for your help and review.

@SimenB SimenB merged commit 49322b6 into facebook:main Feb 28, 2022
24 of 26 checks passed
@TrickyPi TrickyPi deleted the feat-12506 branch Feb 28, 2022
@github-actions
Copy link

github-actions bot commented Mar 31, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Throw when multiple configs are found
3 participants