Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace hash routine md5 with sha256 #12722

Merged
merged 2 commits into from
Apr 25, 2022
Merged

fix: replace hash routine md5 with sha256 #12722

merged 2 commits into from
Apr 25, 2022

Conversation

darmbrust
Copy link
Contributor

swapping out the md5 hash routine with sha256 (truncated to 32 chars)
and base64url encoded.
this allows jest to run on a system where openssl is in a fips enabled
mode.

Summary

#10726

Test plan

ran e2e tests.

swapping out the md5 hash routine with sha256 (truncated to 32 chars)
and base64url encoded.
this allows jest to run on a system where openssl is in a fips enabled
mode.
@facebook-github-bot
Copy link
Contributor

Hi @darmbrust!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool thanks! Do you know of a way we can run our tests on a fips system? Via some docker image or something?

Also, please add a changelog entry 🙂

@SimenB
Copy link
Member

SimenB commented Apr 25, 2022

I'm unable to find any way of actually testing this (and not even any eslint rule to ban md5), so this is a best effort thing that will probably break. However, can land for now to hopefully unblock folks

@SimenB SimenB changed the title replace hash routine md5 with sha256 fix: replace hash routine md5 with sha256 Apr 25, 2022
@SimenB SimenB merged commit fc85b8f into jestjs:main Apr 25, 2022
@darmbrust
Copy link
Contributor Author

If you have redhat 8 running in a VM or something, enabling fips mode is pretty easy:
https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/8/html/security_hardening/using-the-system-wide-cryptographic-policies_security-hardening#switching-the-system-to-fips-mode_using-the-system-wide-cryptographic-policies

Its a bit trickier in a docker image, because there is a kernel boot flag involved, which you can't set independently for a docker container.
The reason we actually got his by this, is because the host running our jenkins / kubernetes build cluster is in fips mode - and when we deployed a redhat 8 image into it as a builder, the 'fips=1' flag from the kernel would be seen in the container, and that was enough to trigger openssl to go into fips mode inside the container.

I couldn't find any way to get openssl to come back out of fips mode when it saw that kernel flag.

@SimenB
Copy link
Member

SimenB commented Apr 25, 2022

If we could get something running on GH Actions, that'd be awesome. Or some other CI provider I guess

F3n67u pushed a commit to F3n67u/jest that referenced this pull request May 2, 2022
Co-authored-by: Dan Armbrust <daniel.armbrust@va.gov>
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants