Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly throw an error if jest-environment-jsdom is missing #12749

Merged
merged 4 commits into from Apr 26, 2022

Conversation

SimenB
Copy link
Collaborator

@SimenB SimenB commented Apr 26, 2022

Summary

WIthout this, we return the jsdom module if it's installed, resulting in a TypeError: TestEnvironment is not a constructor.

image

Test plan

Tested manually in a reproduction. Hard to test in this repo due to jest-environment-jsdom being present

packages/jest-resolve/src/utils.ts Outdated Show resolved Hide resolved
Co-authored-by: Michał Pierzchała <thymikee@gmail.com>
CHANGELOG.md Outdated Show resolved Hide resolved
@SimenB SimenB merged commit ffda59f into facebook:main Apr 26, 2022
89 checks passed
@SimenB SimenB deleted the jsdom-resolve-error branch Apr 26, 2022
@SimenB
Copy link
Collaborator Author

SimenB commented Apr 26, 2022

@github-actions
Copy link

github-actions bot commented Jun 18, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants