Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jest-mock): ensure mock resolved and rejected values are promises from correct realm #13503

Merged
merged 2 commits into from Oct 24, 2022

Conversation

SimenB
Copy link
Collaborator

@SimenB SimenB commented Oct 24, 2022

Summary

Fixes #6645

Test plan

Test added, so Green CI

@mhombach
Copy link

This also fixes #13206 , right? :)

@SimenB
Copy link
Collaborator Author

SimenB commented Oct 24, 2022

Possibly! 🙂 Original repo there gives me ReferenceError: fakeAsync is not defined. But it fixes the instanceof issue

@SimenB SimenB merged commit 5fea130 into facebook:main Oct 24, 2022
78 checks passed
@SimenB SimenB deleted the mock-function-promise-instanceof branch October 24, 2022 09:30
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mockResolvedValue / mockRejectedValue should returns a real Promise
3 participants