Only harmonizing if we need to... allows debugging to be possible #153

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@facebook-github-bot

This comment has been minimized.

Show comment
Hide comment
@facebook-github-bot

facebook-github-bot Oct 16, 2014

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@facebook-github-bot

This comment has been minimized.

Show comment
Hide comment
@facebook-github-bot

facebook-github-bot Oct 16, 2014

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@@ -394,7 +394,9 @@ function _main(onComplete) {
exports.runCLI = runCLI;
if (require.main === module) {
- harmonize();
+ if (process.execArgv.indexOf('--harmony') === -1) {

This comment has been minimized.

@jeffmo

jeffmo Nov 3, 2014

Member

It seems the harmonize module already does this (albeit in a slightly different way):
https://github.com/dcodeIO/node-harmonize/blob/master/harmonize.js#L25

@jeffmo

jeffmo Nov 3, 2014

Member

It seems the harmonize module already does this (albeit in a slightly different way):
https://github.com/dcodeIO/node-harmonize/blob/master/harmonize.js#L25

@jeffmo

This comment has been minimized.

Show comment
Hide comment
@jeffmo

jeffmo Nov 13, 2014

Member

Closing out because it's not clear this is necessary. Let me know if I've missed something and we can re-open

Member

jeffmo commented Nov 13, 2014

Closing out because it's not clear this is necessary. Let me know if I've missed something and we can re-open

@jeffmo jeffmo closed this Nov 13, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment