Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pretty-print React elements #1566

Merged
merged 3 commits into from Sep 1, 2016
Merged

Pretty-print React elements #1566

merged 3 commits into from Sep 1, 2016

Conversation

@gaearon
Copy link
Member

@gaearon gaearon commented Sep 1, 2016

Fixes #1429.
Fixes #1509.

Adds pretty-printing of elements both to regular tests (yay shallow rendering diffs!) and to snapshot tests (which had pretty-printing for instances but not for elements).

screen shot 2016-09-01 at 16 31 54

screen shot 2016-09-01 at 16 33 59

Fixes #1429
Fixes #1509
@ghost ghost added the CLA Signed ✔️ label Sep 1, 2016
cpojer added 2 commits Sep 1, 2016
@cpojer
Copy link
Contributor

@cpojer cpojer commented Sep 1, 2016

Awesome! I just updated some minor require odering nit.

@codecov-io
Copy link

@codecov-io codecov-io commented Sep 1, 2016

Current coverage is 90.37% (diff: 100%)

Merging #1566 into master will increase coverage by 0.10%

@@             master      #1566   diff @@
==========================================
  Files            28         28          
  Lines          1121       1133    +12   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           1012       1024    +12   
  Misses          109        109          
  Partials          0          0          

Powered by Codecov. Last update d45f813...221d409

@cpojer cpojer merged commit 5a72b1d into master Sep 1, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@gaearon gaearon deleted the jsx branch Sep 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants