Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Fix possibly confusing typo #2937

Merged
merged 1 commit into from Feb 19, 2017
Merged

Conversation

@happycollision
Copy link
Contributor

@happycollision happycollision commented Feb 17, 2017

I have always struggled getting mocks to work properly and this possible typo has always contributed to the problem. I say "possible" because I still am not super comfortable with what jest.mock actually does.

Summary

Test plan

I have always struggled getting mocks to work properly and this possible typo has always contributed to the problem. I say "possible" because I still am not super comfortable with what `jest.mock` actually does.
@facebook-github-bot
Copy link
Contributor

@facebook-github-bot facebook-github-bot commented Feb 17, 2017

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

Copy link
Collaborator

@thymikee thymikee left a comment

Thank you!

@happycollision happycollision changed the title Fix possibly confusing typo Documentation: Fix possibly confusing typo Feb 17, 2017
@facebook-github-bot
Copy link
Contributor

@facebook-github-bot facebook-github-bot commented Feb 17, 2017

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@happycollision
Copy link
Contributor Author

@happycollision happycollision commented Feb 17, 2017

I'm not sure how a documentation change could throw a CI build test, but you can see the only thing I changed was adding a period to a code example.

@thymikee
Copy link
Collaborator

@thymikee thymikee commented Feb 17, 2017

Happens sometimes, it's not your fault. I've restarted the build

@codecov-io
Copy link

@codecov-io codecov-io commented Feb 17, 2017

Codecov Report

Merging #2937 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2937   +/-   ##
=======================================
  Coverage   67.94%   67.94%           
=======================================
  Files         146      146           
  Lines        5303     5303           
=======================================
  Hits         3603     3603           
  Misses       1700     1700

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9fc134...597fa77. Read the comment docs.

@cpojer cpojer merged commit 8f6a53b into facebook:master Feb 19, 2017
3 checks passed
3 checks passed
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
skovhus added a commit to skovhus/jest that referenced this pull request Apr 29, 2017
I have always struggled getting mocks to work properly and this possible typo has always contributed to the problem. I say "possible" because I still am not super comfortable with what `jest.mock` actually does.
tushardhole pushed a commit to tushardhole/jest that referenced this pull request Aug 21, 2017
I have always struggled getting mocks to work properly and this possible typo has always contributed to the problem. I say "possible" because I still am not super comfortable with what `jest.mock` actually does.
@github-actions
Copy link

@github-actions github-actions bot commented May 13, 2021

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants