Fix inconsistent name of complex values in pretty-format

[pedrottimark]

Summary

Give the return statements in printComplexValue a parallel structure.

• For min: true option, the previous formatted value Array [] instead of [] for empty array (or arguments) was inconsistent with {} for empty object. The change doesn’t affect snapshots directly, but it does affect format of Expected/Received values in Jest output when a test fails.
• When hitMaxDepth is true, the change to return name of typed array or constructed object instead of generic [Array] or [Object] doesn’t affect snapshots because default maxDepth is Infinity but does affect Jest output when a test fails, because maxDepth = 10 is default.

Test plan

Updated tests for min: true option in jest-matchers and jest-matcher-utils

[pedrottimark]

This fails when I run tests locally after yarn clean-all && yarn but I didn’t dare to update it:

 FAIL  integration_tests/__tests__/show_config.test.js
  ● jest --showConfig › outputs config info and exits

-        "/mocked/root/path/jest/node_modules/babel-jest/build/index.js"
+        "/mocked/root/path/jest/integration_tests/verbose_reporter/node_modules/babel-jest/build/index.js"

[thymikee]

Love what you're doing to make pretty-format code better and easier to approach ❤️

[pedrottimark]

Just remembered what is the breaking change for snapshots: an empty typed array becomes Unit32Array [] instead of Array []

[cpojer]

Seems like Appveyor is unhappy about some snapshots?

[pedrottimark]

Yes, I think about 15 added/removed because of Array [] to [] in their names.

[pedrottimark]

I will look at Jest code to see if an unintended side effect of --ci option is default unminified instead of min: true option for Expected/Received values? EDIT: Does not seem relevant.

[pedrottimark]

Could it be caching, because no source files change in jest-matchers or jest-matcher-utils

• matchers.test.js.snap and spy_matchers.test.js.snap changed but not the corresponding .test.js files, because they call stringify in template literals for the snapshot tests than changed.
• More surprising to me is index.test.js in jest-matcher-utils because I did edit the test file.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.