New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the reference from `react-addons-test-utils` to `react-dom/test-utils` Fixes #4202 #4204

Merged
merged 2 commits into from Aug 7, 2017

Conversation

Projects
None yet
4 participants
@kidkkr
Copy link
Contributor

kidkkr commented Aug 6, 2017

ReactTestUtils has been moved to react-dom/test-utils

Summary
Update refrences from react-addons-test-utils to react-dom/test-utils
in jest/examples/typescript/tests/checkbox_with_label.test.tsx

Add react and react-dom to package.json

Test plan

Update checkbox_with_label.test.tsx
ReactTestUtils has been moved to react-dom/test-utils
@facebook-github-bot

This comment has been minimized.

Copy link

facebook-github-bot commented Aug 6, 2017

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Aug 6, 2017

Codecov Report

Merging #4204 into master will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4204      +/-   ##
==========================================
+ Coverage   60.18%   60.27%   +0.09%     
==========================================
  Files         191      198       +7     
  Lines        6763     6779      +16     
  Branches        6        6              
==========================================
+ Hits         4070     4086      +16     
  Misses       2690     2690              
  Partials        3        3
Impacted Files Coverage Δ
packages/pretty-format/src/collections.js 100% <0%> (ø) ⬆️
packages/pretty-format/src/plugins/immutable.js
...ackages/pretty-format/src/plugins/immutable_map.js 100% <0%> (ø)
...ckages/pretty-format/src/plugins/immutable_list.js 100% <0%> (ø)
...ages/pretty-format/src/plugins/immutable_record.js 100% <0%> (ø)
...kages/pretty-format/src/plugins/immutable_stack.js 100% <0%> (ø)
...pretty-format/src/plugins/immutable_ordered_map.js 100% <0%> (ø)
...s/pretty-format/src/plugins/lib/print_immutable.js 100% <0%> (ø)
...pretty-format/src/plugins/immutable_ordered_set.js 100% <0%> (ø)
...ackages/pretty-format/src/plugins/immutable_set.js 100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee928fd...68969c7. Read the comment docs.

@cpojer cpojer merged commit 3f6422d into facebook:master Aug 7, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@cpojer

This comment has been minimized.

Copy link
Contributor

cpojer commented Aug 7, 2017

Thank you!

tushardhole pushed a commit to tushardhole/jest that referenced this pull request Aug 21, 2017

Update the reference from `react-addons-test-utils` to `react-dom/tes…
…t-utils` Fixes facebook#4202 (facebook#4204)

* Update checkbox_with_label.test.tsx

ReactTestUtils has been moved to react-dom/test-utils

* Add react, react-dom dependencies facebook#4202

midzelis added a commit to midzelis/jest that referenced this pull request Aug 30, 2017

Update the reference from `react-addons-test-utils` to `react-dom/tes…
…t-utils` Fixes facebook#4202 (facebook#4204)

* Update checkbox_with_label.test.tsx

ReactTestUtils has been moved to react-dom/test-utils

* Add react, react-dom dependencies facebook#4202
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment