Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
add only-failures mode #4886
In the current form, the plugin system doesn't allow it.
@@ Coverage Diff @@ ## master #4886 +/- ## ========================================== - Coverage 60.74% 60.72% -0.02% ========================================== Files 198 200 +2 Lines 6605 6638 +33 Branches 4 4 ========================================== + Hits 4012 4031 +19 - Misses 2593 2607 +14
Dec 15, 2017
6 checks passed
Let's do it for Jest 22. @lsentkiewicz thanks so much for sending this PR and thanks to all the reviewers for getting this into a good shape. I still have concerns that this will make people unaware of tests that start failing while in this mode that won't be captured by this, and that may be confusing for people. I'm fine with this because I think it still speeds up the process of fixing a bunch of tests even if you have to run all tests once at the end and fix up other stuff.
referenced this pull request
Dec 27, 2017
I share the same concern. I see how this can make fixing some bugs faster but I'm unsure if the benefit outweighs the risk of some failing tests going unnoticed.
This mode can also increase the user's cognitive load. Since it re-tests only the originally failing tests, the user has to remember which tests were failing to know what was actually tested.
After the tests pass it shows a text "No failed test found.". This can be misleading since there might actually be other failing tests. It would be more clear if after the tests have been fixed it would show the list of all the originally failing tests with a "PASS" label next to them.