fix(jest-cli): use import-local
to support global Jest installations
#5304
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We have some custom code to check for
<rootDir>/node_modules/jest-cli
and if it's there, use it. This is (from what I can understand) to support using a global Jest installation to run a local installation.The problem is that it breaks the assumption of node resolution algorithms, leading to weird errors like #5119.
This PR replaces the logic within
jest-cli
to useimport-local
in the entry point, similar to howxo
,webpack-dev-server
etc. do it.The theory is that you only want this logic when running jest as a binary, not when using the programmatic API. Might be considered a breaking change, dunno?
Fixes #5294.
Test plan
I'm not sure how to properly test installing jest globally. Is it good enough to do
yarn link
and running the global bin? If so, this works.