Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a documentation note for project displayName configuration #5600

Merged
merged 2 commits into from Feb 17, 2018

Conversation

@ronami
Copy link
Contributor

ronami commented Feb 17, 2018

Summary

This PR addresses issue: #4379. Please let me know if something should be changed.

Test plan

Simply docs, no tests 馃檪

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 17, 2018

Codecov Report

Merging #5600 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5600      +/-   ##
==========================================
+ Coverage   60.62%   60.63%   +<.01%     
==========================================
  Files         213      213              
  Lines        7312     7313       +1     
  Branches        3        3              
==========================================
+ Hits         4433     4434       +1     
  Misses       2878     2878              
  Partials        1        1
Impacted Files Coverage 螖
packages/jest-config/src/normalize.js 93.4% <0%> (酶) 猬嗭笍
packages/jest-cli/src/search_source.js 45.83% <0%> (+0.76%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update e89de4e...8d7f281. Read the comment docs.

@rickhanlonii

This comment has been minimized.

Copy link
Member

rickhanlonii commented Feb 17, 2018

Looks great, thanks!

@rickhanlonii rickhanlonii merged commit 4e4a9e0 into facebook:master Feb 17, 2018
6 checks passed
6 checks passed
ci/circleci: test-and-deploy-website Your tests passed on CircleCI!
Details
ci/circleci: test-browser Your tests passed on CircleCI!
Details
ci/circleci: test-node-6 Your tests passed on CircleCI!
Details
ci/circleci: test-node-8 Your tests passed on CircleCI!
Details
ci/circleci: test-node-9 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@ronami ronami deleted the ronami:display-name-note branch Feb 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can鈥檛 perform that action at this time.