Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Handle arrays when merging snapshots #7089
#6455 fixes properties in an object being left out of the snapshot if they are not specified in
However, arrays are not being merged so fields are being left out in the snapshot. For example:
The test case has been updated to include an array to be merged for testing
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.
If you have received this in error or have any questions, please contact us at email@example.com. Thanks!
referenced this pull request
Apr 22, 2019
@@ Coverage Diff @@ ## master #7089 +/- ## ========================================== + Coverage 62.22% 62.22% +<.01% ========================================== Files 266 266 Lines 10720 10731 +11 Branches 2609 2611 +2 ========================================== + Hits 6670 6677 +7 - Misses 3463 3465 +2 - Partials 587 589 +2
Apr 22, 2019
11 checks passed
I have to revert this PR for now. It introduces a simple regression around strings being converted to objects, which I took the time to fix here scotthovestadt@3fd5434 but it also introduces a regression around breaking
Happy to have this merged in once it doesn't break those use-cases.