Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "should_instrument" decision when given negative testMatch pattern #7170

Merged
merged 1 commit into from Oct 16, 2018

Conversation

Projects
None yet
3 participants
@g-harel
Copy link
Contributor

commented Oct 15, 2018

Summary

Files that match with the testFiles configuration aren't instrumented for test coverage.

This check was being done with multimatch.any which behaves unexpectedly when given an inverse glob pattern (!**/dont/**/*.js).

Issue: #7165
Reproduction: https://github.com/g-harel/jest-7165

Test plan

I've modified an existing test case to verify that the fix works.

I also linked my local fork to the reproduction project to confirm that the change had the intended effect.

@facebook-github-bot

This comment has been minimized.

Copy link

commented Oct 15, 2018

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot

This comment has been minimized.

Copy link

commented Oct 15, 2018

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@SimenB

SimenB approved these changes Oct 15, 2018

Copy link
Collaborator

left a comment

Can you update the changelog?

@g-harel g-harel force-pushed the g-harel:should-instrument-negative-glob branch from 0db96b3 to f0a8fab Oct 15, 2018

@g-harel

This comment has been minimized.

Copy link
Contributor Author

commented Oct 15, 2018

@SimenB done ✔️

@SimenB SimenB merged commit ec87f3d into facebook:master Oct 16, 2018

10 checks passed

ci/circleci: lint-and-typecheck Your tests passed on CircleCI!
Details
ci/circleci: test-browser Your tests passed on CircleCI!
Details
ci/circleci: test-jest-circus Your tests passed on CircleCI!
Details
ci/circleci: test-node-10 Your tests passed on CircleCI!
Details
ci/circleci: test-node-6 Your tests passed on CircleCI!
Details
ci/circleci: test-node-8 Your tests passed on CircleCI!
Details
ci/circleci: test-or-deploy-website Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.