Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
fix(jest-config): Allow exactly one project #7498
This fixes the issue described in #7496, where Jest ignores the project's configuration if the config's
I've tested that it works in my reproduction case, but I'm not sure how to write a test case for it, or why the test checked
I'll be happy to write a test if someone nudges me in the right direction!
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.
If you have received this in error or have any questions, please contact us at email@example.com. Thanks!
#5176 is for object config, not a string pointing to a directory containing config.
An integration test in
referenced this pull request
Dec 11, 2018
I've added an e2e test which demonstrates the issue (breaks before the change from
However, the change seems to affect other stuff. Based on the other integration test that now breaks, my guess is that the root project counts towards the
Perhaps the root project should always be counted, even when
There is some config that only applies to the root project (