Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate jest-docblock to TypeScript #7836

Merged
merged 2 commits into from Feb 8, 2019

Conversation

@SimenB
Copy link
Collaborator

SimenB commented Feb 8, 2019

Summary

Built diff:

diff --git c/packages/jest-docblock/build/index.js w/packages/jest-docblock/build/index.js
index 8c60ffcd1..24f2b052c 100644
--- c/packages/jest-docblock/build/index.js
+++ w/packages/jest-docblock/build/index.js
@@ -9,20 +9,20 @@ exports.parse = parse;
 exports.parseWithComments = parseWithComments;
 exports.print = print;
 
-function _detectNewline() {
-  const data = _interopRequireDefault(require('detect-newline'));
+function _os() {
+  const data = require('os');
 
-  _detectNewline = function _detectNewline() {
+  _os = function _os() {
     return data;
   };
 
   return data;
 }
 
-function _os() {
-  const data = require('os');
+function _detectNewline() {
+  const data = _interopRequireDefault(require('detect-newline'));
 
-  _os = function _os() {
+  _detectNewline = function _detectNewline() {
     return data;
   };
 
@@ -38,8 +38,6 @@ function _interopRequireDefault(obj) {
  *
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
- *
- *
  */
 const commentEndRe = /\*\/$/;
 const commentStartRe = /^\/\*\*/;

Test plan

Green CI

@SimenB SimenB force-pushed the SimenB:ts-docblock branch from 9350b1e to ab46da3 Feb 8, 2019
@SimenB SimenB added this to the TypeScript Migration milestone Feb 8, 2019
@jeysal
jeysal approved these changes Feb 8, 2019
@SimenB SimenB merged commit d96ff2c into facebook:master Feb 8, 2019
10 of 12 checks passed
10 of 12 checks passed
facebook.jest #20190208.16 failed
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
ci/circleci: lint-and-typecheck Your tests passed on CircleCI!
Details
ci/circleci: test-browser Your tests passed on CircleCI!
Details
ci/circleci: test-jest-circus Your tests passed on CircleCI!
Details
ci/circleci: test-node-10 Your tests passed on CircleCI!
Details
ci/circleci: test-node-11 Your tests passed on CircleCI!
Details
ci/circleci: test-node-6 Your tests passed on CircleCI!
Details
ci/circleci: test-node-8 Your tests passed on CircleCI!
Details
ci/circleci: test-or-deploy-website Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
@SimenB SimenB deleted the SimenB:ts-docblock branch Feb 8, 2019
SerhiiBilyk added a commit to SerhiiBilyk/jest that referenced this pull request Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.