Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: run typescript build as part of typecheck, not normal build #7855

Merged
merged 3 commits into from Feb 13, 2019

Conversation

@SimenB
Copy link
Collaborator

SimenB commented Feb 11, 2019

Summary

That way type errors will not block unit tests from running

Test plan

Green CI

@SimenB SimenB added this to the TypeScript Migration milestone Feb 11, 2019
@SimenB SimenB requested a review from thymikee Feb 11, 2019
package.json Show resolved Hide resolved
fs.existsSync(path.resolve(p, 'tsconfig.json'))
);

execa.sync('tsc', ['-b', ...packageWithTs, ...process.argv.slice(2)], {

This comment has been minimized.

Copy link
@SimenB

SimenB Feb 11, 2019

Author Collaborator

Makes node scripts/typeScriptBuild.js --watch work

@SimenB SimenB requested a review from rubennorte Feb 11, 2019
Copy link
Collaborator

thymikee left a comment

Great!

package.json Outdated Show resolved Hide resolved
scripts/typeScriptBuild.js Outdated Show resolved Hide resolved
SimenB added 2 commits Feb 11, 2019
@SimenB

This comment has been minimized.

Copy link
Collaborator Author

SimenB commented Feb 13, 2019

Ok, ended up adding build:ts which builds type definitions. Also added prebuild: build:ts, so it triggers automatically before build. Also added watch:ts which runs tsc in watch mode

@SimenB SimenB merged commit 300de98 into facebook:master Feb 13, 2019
3 of 12 checks passed
3 of 12 checks passed
ci/circleci: test-jest-circus CircleCI is running your tests
Details
ci/circleci: test-node-10 CircleCI is running your tests
Details
ci/circleci: test-node-11 CircleCI is running your tests
Details
ci/circleci: test-node-6 CircleCI is running your tests
Details
ci/circleci: test-node-8 CircleCI is running your tests
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
deploy/netlify Deploy preview processing.
Details
facebook.jest in progress
Details
ci/circleci: lint-and-typecheck Your tests passed on CircleCI!
Details
ci/circleci: test-browser Your tests passed on CircleCI!
Details
ci/circleci: test-or-deploy-website Your tests passed on CircleCI!
Details
@SimenB SimenB deleted the SimenB:ts-build branch Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.