Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upInherit "only" mode unless there is tests with "only" mode already #7888
Conversation
This comment has been minimized.
This comment has been minimized.
It is little verbose solution. Welcome to other solutions |
This comment has been minimized.
This comment has been minimized.
codecov-io
commented
Feb 14, 2019
Codecov Report
@@ Coverage Diff @@
## master #7888 +/- ##
==========================================
- Coverage 58.15% 58.08% -0.08%
==========================================
Files 173 173
Lines 6424 6427 +3
Branches 5 5
==========================================
- Hits 3736 3733 -3
- Misses 2686 2692 +6
Partials 2 2
Continue to review full report at Codecov.
|
Thanks, this looks good! Left a comment about the integration test, beyond that this lgtm |
Thanks a lot for fixing this! Left some comments :) |
Thanks! |
696d424
into
facebook:master
10 of 12 checks passed
10 of 12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
doniyor2109 commentedFeb 14, 2019
Summary
Fixes #7837
Test plan
yarn test