Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inherit "only" mode unless there is tests with "only" mode already #7888

Merged
merged 12 commits into from Feb 14, 2019

Conversation

@doniyor2109
Copy link
Contributor

doniyor2109 commented Feb 14, 2019

Summary

Fixes #7837

Test plan

yarn test

doniyor2109 added 2 commits Feb 14, 2019
# Conflicts:
#	CHANGELOG.md
@doniyor2109

This comment has been minimized.

Copy link
Contributor Author

doniyor2109 commented Feb 14, 2019

It is little verbose solution. Welcome to other solutions

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 14, 2019

Codecov Report

Merging #7888 into master will decrease coverage by 0.07%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7888      +/-   ##
==========================================
- Coverage   58.15%   58.08%   -0.08%     
==========================================
  Files         173      173              
  Lines        6424     6427       +3     
  Branches        5        5              
==========================================
- Hits         3736     3733       -3     
- Misses       2686     2692       +6     
  Partials        2        2
Impacted Files Coverage Δ
packages/jest-circus/src/utils.js 18.48% <ø> (-2.01%) ⬇️
packages/jest-circus/src/eventHandler.js 10.97% <0%> (-0.87%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e31173...9429103. Read the comment docs.

Copy link
Collaborator

SimenB left a comment

Thanks, this looks good!

Left a comment about the integration test, beyond that this lgtm

e2e/__tests__/jestCircus.test.js Outdated Show resolved Hide resolved
packages/jest-circus/src/eventHandler.js Outdated Show resolved Hide resolved
doniyor2109 added 5 commits Feb 14, 2019
# Conflicts:
#	CHANGELOG.md
Copy link
Collaborator

jeysal left a comment

Thanks a lot for fixing this! Left some comments :)

packages/jest-circus/src/eventHandler.js Outdated Show resolved Hide resolved
e2e/Utils.js Outdated Show resolved Hide resolved
doniyor2109 and others added 3 commits Feb 14, 2019
Co-Authored-By: doniyor2109 <doniyor2109@gmail.com>
@SimenB
SimenB approved these changes Feb 14, 2019
Copy link
Collaborator

SimenB left a comment

Thanks!

@SimenB SimenB merged commit 696d424 into facebook:master Feb 14, 2019
10 of 12 checks passed
10 of 12 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
facebook.jest #20190214.20 failed
Details
ci/circleci: lint-and-typecheck Your tests passed on CircleCI!
Details
ci/circleci: test-browser Your tests passed on CircleCI!
Details
ci/circleci: test-jest-circus Your tests passed on CircleCI!
Details
ci/circleci: test-node-10 Your tests passed on CircleCI!
Details
ci/circleci: test-node-11 Your tests passed on CircleCI!
Details
ci/circleci: test-node-6 Your tests passed on CircleCI!
Details
ci/circleci: test-node-8 Your tests passed on CircleCI!
Details
ci/circleci: test-or-deploy-website Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.