Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: extract FakeTimers into a separate package #7987

Merged
merged 3 commits into from Feb 26, 2019

Conversation

@SimenB
Copy link
Collaborator

SimenB commented Feb 25, 2019

Summary

Makes the types easier to use. And makes jest-util smaller. Win-win!

(export kept in jest-util to avoid the breaking change.)

Test plan

Green CI

@SimenB SimenB force-pushed the SimenB:extract-fake-timers branch from 62559db to f70c255 Feb 25, 2019
* LICENSE file in the root directory of this source tree.
*/

export {default as JestFakeTimers} from './jestFakeTimers';

This comment has been minimized.

Copy link
@SimenB

SimenB Feb 25, 2019

Author Collaborator

Not default export since I want to keep the door open for Lolex as an alternative, ref #7776

@cpojer
cpojer approved these changes Feb 26, 2019
Copy link
Contributor

cpojer left a comment

Cool!

@SimenB SimenB merged commit 419661f into facebook:master Feb 26, 2019
11 of 12 checks passed
11 of 12 checks passed
facebook.jest #20190225.40 failed
Details
ci/circleci: lint-and-typecheck Your tests passed on CircleCI!
Details
ci/circleci: test-browser Your tests passed on CircleCI!
Details
ci/circleci: test-jest-circus Your tests passed on CircleCI!
Details
ci/circleci: test-node-10 Your tests passed on CircleCI!
Details
ci/circleci: test-node-11 Your tests passed on CircleCI!
Details
ci/circleci: test-node-6 Your tests passed on CircleCI!
Details
ci/circleci: test-node-8 Your tests passed on CircleCI!
Details
ci/circleci: test-or-deploy-website Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
@SimenB SimenB deleted the SimenB:extract-fake-timers branch Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.