Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup JestEnvironment types #7988

Merged
merged 2 commits into from Feb 26, 2019

Conversation

@SimenB
Copy link
Collaborator

SimenB commented Feb 26, 2019

Summary

Played around with it in #7985, and these were the changes I had to make to allow us to do class NodeEnvironment extends JestEnvironment and get proper typings

Test plan

Green CI

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 26, 2019

Codecov Report

Merging #7988 into master will not change coverage.
The diff coverage is 25%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7988   +/-   ##
=======================================
  Coverage   64.54%   64.54%           
=======================================
  Files         257      257           
  Lines       10076    10076           
  Branches     1586     1587    +1     
=======================================
  Hits         6504     6504           
  Misses       3230     3230           
  Partials      342      342
Impacted Files Coverage Δ
...circus/src/legacy-code-todo-rewrite/jestAdapter.ts 0% <0%> (ø) ⬆️
packages/jest-runner/src/runTest.ts 2.59% <0%> (ø) ⬆️
packages/jest-runtime/src/index.ts 68.98% <40%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 419661f...e66b668. Read the comment docs.

@SimenB SimenB merged commit 16fe18d into facebook:master Feb 26, 2019
0 of 11 checks passed
0 of 11 checks passed
ci/circleci: lint-and-typecheck CircleCI is running your tests
Details
ci/circleci: test-browser CircleCI is running your tests
Details
ci/circleci: test-jest-circus CircleCI is running your tests
Details
ci/circleci: test-node-10 CircleCI is running your tests
Details
ci/circleci: test-node-11 CircleCI is running your tests
Details
ci/circleci: test-node-6 CircleCI is running your tests
Details
ci/circleci: test-node-8 CircleCI is running your tests
Details
ci/circleci: test-or-deploy-website CircleCI is running your tests
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
deploy/netlify Deploy preview processing.
Details
@SimenB SimenB deleted the SimenB:tweak-jest-environment-type branch Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.