Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: create new `@jest/console` package #8030

Merged
merged 1 commit into from Mar 3, 2019

Conversation

@SimenB
Copy link
Collaborator

SimenB commented Mar 3, 2019

Summary

Keep cutting away at jest-util. First commit is from #8029, ignore it.

Test plan

Green CI

@SimenB SimenB changed the title Jest console chore: create new `@jest/console` package Mar 3, 2019
@SimenB SimenB force-pushed the SimenB:jest-console branch 2 times, most recently from 8256295 to e17c919 Mar 3, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 3, 2019

Codecov Report

Merging #8030 into master will decrease coverage by 0.01%.
The diff coverage is 37.5%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #8030      +/-   ##
=========================================
- Coverage   63.31%   63.3%   -0.02%     
=========================================
  Files         263     263              
  Lines       10266   10268       +2     
  Branches     2098    2100       +2     
=========================================
  Hits         6500    6500              
- Misses       3273    3275       +2     
  Partials      493     493
Impacted Files Coverage Δ
packages/jest-runtime/src/index.ts 68.98% <ø> (ø) ⬆️
packages/jest-source-map/src/getCallsite.ts 75% <ø> (ø)
packages/jest-console/src/getConsoleOutput.ts 0% <ø> (ø)
packages/jest-runner/src/runTest.ts 2.53% <0%> (ø) ⬆️
packages/jest-console/src/BufferedConsole.ts 70% <100%> (ø)
packages/jest-core/src/runJest.ts 33.78% <33.33%> (ø) ⬆️
packages/jest-console/src/CustomConsole.ts 68.75% <50%> (ø)
packages/jest-util/src/clearLine.ts 0% <0%> (-50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c25942...110da28. Read the comment docs.

@SimenB SimenB requested a review from thymikee Mar 3, 2019
Copy link
Collaborator

thymikee left a comment

makes sense 👍

config: Config.ProjectConfig,
) {
// @ts-ignore: `_log` is `private` - we should figure out some proper API here
testConsole._log = function fakeConsolePush(

This comment has been minimized.

Copy link
@thymikee

thymikee Mar 3, 2019

Collaborator

sounds like a nice followup to have a setter for that

This comment has been minimized.

Copy link
@SimenB

SimenB Mar 3, 2019

Author Collaborator

yeah, some sort of "disable logging" would be nice. We inject the instance into the sandbox though, so probably hide it behind a Symbol or something

@SimenB SimenB force-pushed the SimenB:jest-console branch from 110da28 to a3ea26c Mar 3, 2019
@SimenB SimenB force-pushed the SimenB:jest-console branch from a3ea26c to 56d8e38 Mar 3, 2019
@SimenB SimenB merged commit bcc2b10 into facebook:master Mar 3, 2019
0 of 11 checks passed
0 of 11 checks passed
ci/circleci: lint-and-typecheck CircleCI is running your tests
Details
ci/circleci: test-browser CircleCI is running your tests
Details
ci/circleci: test-jest-circus CircleCI is running your tests
Details
ci/circleci: test-node-10 CircleCI is running your tests
Details
ci/circleci: test-node-11 CircleCI is running your tests
Details
ci/circleci: test-node-6 CircleCI is running your tests
Details
ci/circleci: test-node-8 CircleCI is running your tests
Details
ci/circleci: test-or-deploy-website CircleCI is running your tests
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
facebook.jest in progress
Details
@SimenB SimenB deleted the SimenB:jest-console branch Mar 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.