Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix retries and error notification in workers #8079

Merged
merged 6 commits into from Mar 7, 2019

Conversation

@rubennorte
Copy link
Contributor

rubennorte commented Mar 7, 2019

Summary

Handling of errors in workers in jest-worker worker is broken which causes several observable issues:

  • Jobs are never retried
  • Errors are not notified (as we're waiting for the retries), so Jest hangs when a worker has an error (fixes #8068)

Test plan

Added unit tests for the workers to make sure messages are re-send to the workers after they're initialized, and an e2e test that makes sure we handle fatal errors in tests properly.

@rubennorte rubennorte requested review from mjesun, SimenB and rickhanlonii and removed request for mjesun Mar 7, 2019
@mjesun
mjesun approved these changes Mar 7, 2019
Copy link
Member

rickhanlonii left a comment

Great fix

@rubennorte rubennorte changed the title Add tests that show that retries are broken in jest-worker Fix retries and error reporting in jest-worker Mar 7, 2019
@rubennorte rubennorte changed the title Fix retries and error reporting in jest-worker Fix retries and error notification in workers Mar 7, 2019
@SimenB
SimenB approved these changes Mar 7, 2019
@rubennorte rubennorte force-pushed the rubennorte:worker-fatal-errors branch from 992d9ab to 10f7a4e Mar 7, 2019
@rubennorte rubennorte added the 🐛 Bug label Mar 7, 2019
@rubennorte rubennorte force-pushed the rubennorte:worker-fatal-errors branch from 10f7a4e to f5f2ed6 Mar 7, 2019
@rubennorte rubennorte force-pushed the rubennorte:worker-fatal-errors branch from 70e173a to df62dd6 Mar 7, 2019
@rubennorte rubennorte force-pushed the rubennorte:worker-fatal-errors branch from 03723d6 to 6cee8b2 Mar 7, 2019
@rubennorte rubennorte merged commit 0c9737e into facebook:master Mar 7, 2019
11 of 12 checks passed
11 of 12 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
ci/circleci: lint-and-typecheck Your tests passed on CircleCI!
Details
ci/circleci: test-browser Your tests passed on CircleCI!
Details
ci/circleci: test-jest-circus Your tests passed on CircleCI!
Details
ci/circleci: test-node-10 Your tests passed on CircleCI!
Details
ci/circleci: test-node-11 Your tests passed on CircleCI!
Details
ci/circleci: test-node-6 Your tests passed on CircleCI!
Details
ci/circleci: test-node-8 Your tests passed on CircleCI!
Details
ci/circleci: test-or-deploy-website Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
facebook.jest #20190307.35 succeeded
Details
@rubennorte rubennorte deleted the rubennorte:worker-fatal-errors branch Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.