Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7846/use property initializer syntax #8117

Merged

Conversation

@peanutenthusiast
Copy link
Contributor

peanutenthusiast commented Mar 12, 2019

Summary

Closes #7846

Test plan

Replaced .bind(this and no arg constructors with property initializer syntax, update jest snapshots when necessary using yarn run jest -u

Copy link
Collaborator

jeysal left a comment

Thanks for the contribution :)

CHANGELOG.md Outdated Show resolved Hide resolved
@jeysal
jeysal approved these changes Mar 12, 2019
Copy link
Collaborator

jeysal left a comment

LGTM, thanks

@peanutenthusiast

This comment has been minimized.

Copy link
Contributor Author

peanutenthusiast commented Mar 13, 2019

Thank you @jeysal !

Copy link
Collaborator

thymikee left a comment

Looks good. Can we add the plugin to examples as well so they can run standalone?

…ig and package files, remove unused constructors with property assignments in react examples, fix prettier errors for same test strings
…bel config and package files, remove unused constructors with property assignments in react examples, fix prettier errors for same test strings"

This reverts commit b22f8e7.
… add babel plugin proposal class properties to babel configs in enzyme and react testing example folders
This reverts commit 49d23b5.
@peanutenthusiast

This comment has been minimized.

Copy link
Contributor Author

peanutenthusiast commented Mar 14, 2019

Is there anything that can be done on my end regarding the CI failures?

@jeysal

This comment has been minimized.

Copy link
Collaborator

jeysal commented Mar 14, 2019

@peanutenthusiast Unless I'm missing something, it looks like you changed one of the snapshots that should not be related in this diff but then Jest gets the old string again? So maybe just run yarn jest detectOpenHandles -u again to revert the snapshot change?

@SimenB
SimenB approved these changes Mar 14, 2019
Copy link
Collaborator

SimenB left a comment

Thanks!

SimenB added 2 commits Mar 14, 2019
@SimenB SimenB merged commit 4f06ee4 into facebook:master Mar 14, 2019
8 of 12 checks passed
8 of 12 checks passed
ci/circleci: test-node-6 CircleCI is running your tests
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
facebook.jest in progress
Details
ci/circleci: lint-and-typecheck Your tests passed on CircleCI!
Details
ci/circleci: test-browser Your tests passed on CircleCI!
Details
ci/circleci: test-jest-circus Your tests passed on CircleCI!
Details
ci/circleci: test-node-10 Your tests passed on CircleCI!
Details
ci/circleci: test-node-11 Your tests passed on CircleCI!
Details
ci/circleci: test-node-8 Your tests passed on CircleCI!
Details
ci/circleci: test-or-deploy-website Your tests passed on CircleCI!
Details
deploy/netlify Deploy preview ready!
Details
@peanutenthusiast peanutenthusiast deleted the peanutenthusiast:7846/use-property-initializer-syntax branch Mar 14, 2019
thymikee added a commit to Brantron/jest that referenced this pull request Mar 19, 2019
* upstream/master: (391 commits)
  more precise circus asyncError types (facebook#8150)
  Add typeahead watch plugin (facebook#6449)
  fix: getTimerCount not taking immediates and ticks into account (facebook#8139)
  website: add an additional filter predicate to backers (facebook#7286)
  [🔥] Revised README (facebook#8076)
  [jest-each] Fix test function type (facebook#8145)
  chore: improve bug template labels for easier maintenance (facebook#8141)
  Add documentation related to auto-mocking (facebook#8099)
  Add support for bigint to pretty-format (facebook#8138)
  Revert "Add fuzzing based tests in Jest (facebook#8012)"
  chore: remove console.log
  chore: Improve description of optional arguments in ExpectAPI.md (facebook#8126)
  Add fuzzing based tests in Jest (facebook#8012)
  Move @types/node to the root package.json (facebook#8129)
  chore: use property initializer syntax (facebook#8117)
  chore: delete flow types from the repo (facebook#8061)
  Move changelog entry to the proper version (facebook#8115)
  Release 24.5.0
  Expose throwOnModuleCollision (facebook#8113)
  add matchers to expect type (facebook#8093)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.