Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[expect] Add negative equality tests #8260

Merged
merged 2 commits into from Apr 3, 2019

Conversation

@mattphillips
Copy link
Collaborator

mattphillips commented Apr 2, 2019

Summary

Hopefully fix #8259

Test plan

Added negative cases outlined in revert and added a few extras

@mattphillips mattphillips changed the title Add negative equality tests [expect] Add negative equality tests Apr 2, 2019
Copy link
Contributor

scotthovestadt left a comment

Thanks for your help resolving this bug!

@scotthovestadt scotthovestadt merged commit 96c19a6 into facebook:master Apr 3, 2019
10 of 11 checks passed
10 of 11 checks passed
ci/circleci: test-jest-circus Your tests failed on CircleCI
Details
ci/circleci: lint-and-typecheck Your tests passed on CircleCI!
Details
ci/circleci: test-browser Your tests passed on CircleCI!
Details
ci/circleci: test-node-10 Your tests passed on CircleCI!
Details
ci/circleci: test-node-11 Your tests passed on CircleCI!
Details
ci/circleci: test-node-6 Your tests passed on CircleCI!
Details
ci/circleci: test-node-8 Your tests passed on CircleCI!
Details
ci/circleci: test-or-deploy-website Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
facebook.jest #20190402.19 succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.